Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32934 )
Change subject: soc/amd/common: Add errors for invalid AcpiMmio access ......................................................................
Patch Set 1:
Furquan, I've tried to address your concerns about access to unsupported functions (https://review.coreboot.org/c/coreboot/+/32649), but do it as cleanly as possible. I'm not sure I like this solution a whole lot, so I'm open to suggestions.
Adding Kconfig symbols and using #if CONFIG() to remove functions is still an option, however that's ~20 additional symbols (which seems to rub some people the wrong way). I could define custom CONFIG_ values in iomap.h and still use CONFIG() to break the build in mmio_util.c vs. printing an error.