Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45337 )
Change subject: soc/intel/{adl,apl,cnl,ehl,icl,jsl,skl,tgl}: Make use of common reset code block ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Change looks mostly okay to me. I just want to make sure that the changes for APL/GLK are not resulting in any regression.
https://review.coreboot.org/c/coreboot/+/45337/5/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45337/5/src/soc/intel/apollolake/Kc... PS5, Line 102: HAVE_CF9_RESET_PREPARE For APL, I think there are two different things:
1. cf9_reset_prepare: This just ensures that CSE is ready for upcoming reset. Used for system_reset and full_reset. This does not itself really do the reset. But, I think we are still going to need this? 2. do_global_reset: Currently, for APL, this does not make use of the CSE to perform the reset. Did you verify that doing a global reset via CSE works for APL/GLK as well?