Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32701 )
Change subject: arch/cpu: Rename mp_get_apic_id() function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@a592
PS1, Line 592:
I would leave this here and add a similar call in `lapic_cpu_init.c`. […]
do you recommend add_cpu_map_entry to move into cpu.c and call the same from here and lapic_cpu_init.c so the flow remain same.
Also lets move cpu_get_apic_id() into cpu.c ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a6c85df055bc0b5fc8c850cfa04d50859067088
Gerrit-Change-Number: 32701
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 09 May 2019 15:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment