Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33625 )
Change subject: Fix NULL dereference issues found by Klocwork ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33625/4/payloads/libpayload/curses/form/fty_... File payloads/libpayload/curses/form/fty_int.c:
https://review.coreboot.org/#/c/33625/4/payloads/libpayload/curses/form/fty_... PS4, Line 175: if (bp == NULL) : return result; Seems like curses code has mix of spaces and tabs. i guess spaces are fine for now, but later we might have to revisit to reformat the code.
https://review.coreboot.org/#/c/33625/4/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/33625/4/src/soc/intel/cannonlake/romstage/fs... PS4, Line 102: : const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC); : const struct device *smbus = dev_find_slot(0, PCH_DEVFN_SMBUS); : if (dev == NULL) : return; push a seperate patch for SOC