[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add USB configuration

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38855 )

Change subject: mb/google/dedede: Add USB configuration
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... 
PS2, Line 22: # USB Port Configuration
> Is USB ACPI configuration planned in a separate CL?

Yes

https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... 
PS2, Line 25: UP_20K
> Are these the POR states for the pads?

By default, the gpio pads are neither pulled up nor pulled down. So I marked as NONE.