Attention is currently required from: Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: vc/google/chromeos: Add low battery indicator screen ......................................................................
Patch Set 6:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/86225/comment/5ec94b6a_67942448?usp... : PS6, Line 105: config CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN I don't think these should be CHROMEOS options, since the code in the next patch is written like any platform can choose to implement these. I think these should probably go in `src/drivers/intel/fsp2_0/Kconfig` (maybe `PLATFORM_HAS_LOW_BATTERY_SHUTDOWN_INDICATOR` and `PLATFORM_HAS_LOW_BATTERY_SHUTDOWN_INDICATOR_EARLY`), and then the ChromeOS vendorcode will just add its logo and build in the platform callbacks if that option is selected.