build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 )
Change subject: {drivers,soc}/intel: Move chipset specific logo handling to SoC ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/apollolake/ch... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/apollolake/ch... PS1, Line 885: return(fsp_load_logo(&supd->FspsConfig.LogoPtr, &supd->FspsConfig.LogoSize)); return is not a function, parentheses are not required
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/cannonlake/fs... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/cannonlake/fs... PS1, Line 491: return(fsp_load_logo(&supd->FspsConfig.LogoPtr, &supd->FspsConfig.LogoSize)); return is not a function, parentheses are not required
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/37792/1/src/soc/intel/skylake/chip.... PS1, Line 424: return(fsp_load_logo(&supd->FspsConfig.LogoPtr, &supd->FspsConfig.LogoSize)); return is not a function, parentheses are not required