Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37222 )
Change subject: soc/amd/stoneyridge|vc: Change default locations for blobs
......................................................................
Patch Set 3:
Looks like this was merged too early before the submodule update
that makes the files available in 3rdparty/amd_blobs/.
Because there's another change that makes it build without the blobs, which generates a very specific warning message without breaking the build. A simple Kconfig inclusion after the blobs become available than includes the blobs.
It's still a regression. Before this change the default paths
were pointing to existing files, now they don't.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5426b8de2501ba55843efc1cda4b03bc3768f8cb
Gerrit-Change-Number: 37222
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 19:53:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment