Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40796 )
Change subject: mainboard/google/kahlee: move specific setting to variant
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
This doesn't hurt anything, but I don't think it's needed right now. Can we keep this one on hold for a bit?
Hi Martin,
the reason I made this change is for specific wlan support and I suppose it'd be better in variant separately to prevent the impact to all grunt boards.
and the benefit is variant could override any change specifically in romstage.
thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I658526e44aadc47bdc5538f506a1bfe2e5f20f63
Gerrit-Change-Number: 40796
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Apr 2020 16:14:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment