[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/xhci: Add support for logging XHCI wake events

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Angel Pons, Martin Roth, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67936 )

Change subject: soc/amd/common/xhci: Add support for logging XHCI wake events
......................................................................

Patch Set 19:

(3 comments)

File src/soc/amd/common/block/acpi/elog.c:

https://review.coreboot.org/c/coreboot/+/67936/comment/28a3394c_0db12c68 
PS19, Line 29: 
Is it being called outside of SMM. If not can we return if (!ENV_SMM)?

https://review.coreboot.org/c/coreboot/+/67936/comment/4f9c76e5_6188ce36 
PS19, Line 34: 		if (ENV_SMM && CONFIG(SOC_AMD_COMMON_BLOCK_XHCI_ELOG) && i == XHCI_GEVENT)
Should this be part of the `if (valid_gpe & (1U << i))` block? Otherwise xhci events might be logged even if the XHCI_GEVENT is not set.

File src/soc/amd/common/block/include/amdblocks/xhci.h:

https://review.coreboot.org/c/coreboot/+/67936/comment/c85ce76f_3ab87d12 
PS19, Line 16: 	SOC_XHCI_0,\
             : 	SOC_XHCI_1,\
             : 	SOC_XHCI_2,\
             : 	SOC_XHCI_3,\
             : 	SOC_XHCI_4,\
             : 	SOC_XHCI_5,\
             : 	SOC_XHCI_6,\
             : 	SOC_XHCI_7,\
Where are they defined?