Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run dram init blob
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/...
PS3, Line 55: printk(BIOS_ERR, "dram_blob error:%d\n", err);
Please add a space after the colon, and rephrase the message, so that it understandable for the user.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad05a77e6353f37cd5ea897203d528762f44176e
Gerrit-Change-Number: 34872
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 10:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment