Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add it8528e
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30957/5/src/superio/ite/it8528e/chip.h
File src/superio/ite/it8528e/chip.h:
PS5:
If you are going to treat the EC part as a (logically) separate chip, […]
I agree.
https://review.coreboot.org/#/c/30957/5/src/superio/ite/it8528e/chip.h@4
PS5, Line 4: * Copyright (C) 2019 Patrick Rudolph patrick.rudolph@9elements.com
There is a tendency to only add copyright notes when they make sense. […]
Well I came up with the super brilliant name "SUPERIO_ITE_IT8528E_CHIP_H" ! That needs to be copyright protected !
I'll change it to 9elements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72aa756e123d6f99d9ef4fe955c4b7f1be25d547
Gerrit-Change-Number: 30957
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Jan 2019 13:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
