Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers
......................................................................
Patch Set 10:
BTW, I just found that 3rdparty/chromeec/include/sfdp.h has similar definition:
SFDP_DEFINE_BITFIELD(SFDP_HEADER_DW1_P, 31, 24);
They also don't put semicolon.
So will it be more clear if we go back to always say BITFIELD?
DEFINE_BITFIELD
EXTRACT_BITFIELD
SET32_BITFIELDS
WRITE32_BITFIELDS
READ32_BITFIELDS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 10
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 21 Sep 2019 14:18:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment