Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED
can't we select SOC_INTEL_COMMON_MMC_OVERRIDE from src/mainboard/goggle/hatch/Kconfig. […]
Please see my comment on previous CL in this set about not requiring the config at all.
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... PS8, Line 53: EDS-Vol2-16.32 Is this for CML? I don't see it in the EDS under this section.