build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45424 )
Change subject: nb/intel/x4x: Place raminit definitions in raminit.h ......................................................................
Patch Set 3:
(13 comments)
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit.h:
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 27: #define IF_DIMM_POPULATED(dimms, idx) if (dimms[idx].card_type != RAW_CARD_UNPOPULATED) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 39: #define FOR_EACH_POPULATED_DIMM(dimms, idx) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 43: #define FOR_EACH_POPULATED_DIMM_IN_CHANNEL(dimms, ch, idx) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 51: #define IF_CHANNEL_POPULATED(dimms, idx) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 56: #define FOR_EACH_POPULATED_CHANNEL(dimms, idx) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 62: ((dimms[(ch<<1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch<<1) + 1].ranks + 2)))) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 63: #define IF_RANK_POPULATED(dimms, ch, r) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 70: #define FOR_EACH_POPULATED_RANK_IN_CHANNEL(dimms, ch, r) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 72: #define FOR_EACH_RANK(ch, r) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 74: #define FOR_EACH_POPULATED_RANK(dimms, ch, r) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 78: #define FOR_EACH_POPULATED_CHANNEL_AND_BYTELANE(dimms, ch, l) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 79: FOR_EACH_POPULATED_CHANNEL (dimms, ch) FOR_EACH_BYTELANE(l) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45424/3/src/northbridge/intel/x4x/r... PS3, Line 213: void do_raminit(struct sysinfo *, int fast_boot); function definition argument 'struct sysinfo *' should also have an identifier name