Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44075 )
Change subject: xeon_sp/cpx: Enable PCH thermal device via FSP
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44075/4/src/soc/intel/xeon_sp/cpx/r...
File src/soc/intel/xeon_sp/cpx/romstage.c:
https://review.coreboot.org/c/coreboot/+/44075/4/src/soc/intel/xeon_sp/cpx/r...
PS4, Line 67: 2: Enabled in ACPI mode
I set it in the chip code and people can still overwrite it in their mainboard_memory_init_params().
Oh sorry, I misunderstood what you meant, reverted back to patchset 4.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39d0d0a982476f9fece51cfa19dcbd0da5dea690
Gerrit-Change-Number: 44075
Gerrit-PatchSet: 6
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 13:02:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment