Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31499 )
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..)
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG@14
PS1, Line 14: 256K smaller then the one defined in IFD.
That was the original intention. Don't cover the 256KiB, because
we can't use it for (memory-mapped) flash storage.
If you use the BIOS region's size, you still can't access the
full BIOS region, you'll access SRAM instead in that area.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic950f28990a645556a04303f04953a7bc5e41a39
Gerrit-Change-Number: 31499
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Gmeiner
christian.gmeiner@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Gmeiner
christian.gmeiner@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Feb 2019 16:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment