Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47658 )
Change subject: commonlib/region: Allow multiple windows for xlate_region_dev
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47658/12/src/soc/intel/apollolake/m...
File src/soc/intel/apollolake/mmap_boot.c:
https://review.coreboot.org/c/coreboot/+/47658/12/src/soc/intel/apollolake/m...
PS12, Line 85: map = rdev_mmap(&real_dev.rdev, region_offset(&cbfs_region), region_sz(&cbfs_region));
: if (map)
: rdev_munmap(&real_dev.rdev, map);
oops should have refreshed, furquan has the same idea. […]
Actually, I changed it back to `region_is_subregion` in patchset #13 to keep it similar to how it was handled before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b21ffca2c8d6a9dfc37a878429aed4a8301651
Gerrit-Change-Number: 47658
Gerrit-PatchSet: 13
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Dec 2020 20:15:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment