Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44917 )
Change subject: soc/intel/tigerlake: Enable and use USB4 PCIe driver ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44917/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/44917/3/src/soc/intel/tigerlake/chi... PS3, Line 8: chip drivers/intel/usb4/pcie : register "port_id" = "0" : use tbt_dma0 as usb4_port : device pci 07.0 alias tbt_pcie_rp0 off end : end I think we should avoid the mistake we did with CNVi device and instead use a virtual generic device:
``` device pci 07.0 alias tbt_pcie_rp0 off chip drivers/intel/usb4/pcie use tbt_dma0 as usb4_port device generic 0 on end end end ```
We can probably encode the port_id in generic ID and drop another register field as well.
Adding the virtual generic device allows us to drop the requirement that the mainboard devicetree has to decorate the TBT devices with "chip drivers/intel/usb4/pcie". All that would be required in mainboard is setting the tbt_pcie_rpX device as on/off depending upon the hardware design.