1 comment:
File src/soc/intel/tigerlake/chipset.cb:
chip drivers/intel/usb4/pcie
register "port_id" = "0"
use tbt_dma0 as usb4_port
device pci 07.0 alias tbt_pcie_rp0 off end
end
I think we should avoid the mistake we did with CNVi device and instead use a virtual generic device:
```
device pci 07.0 alias tbt_pcie_rp0 off
chip drivers/intel/usb4/pcie
use tbt_dma0 as usb4_port
device generic 0 on end
end
end
```
We can probably encode the port_id in generic ID and drop another register field as well.
Adding the virtual generic device allows us to drop the requirement that the mainboard devicetree has to decorate the TBT devices with "chip drivers/intel/usb4/pcie". All that would be required in mainboard is setting the tbt_pcie_rpX device as on/off depending upon the hardware design.
To view, visit change 44917. To unsubscribe, or for help writing mail filters, visit settings.