Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42832 )
Change subject: mb/google/zork: Add Bluetooth reset gpios to devicetree ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42832/11/src/mainboard/google/zork/... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/42832/11/src/mainboard/google/zork/... PS11, Line 117:
nit: extra blank line not required.
Done
https://review.coreboot.org/c/coreboot/+/42832/11/src/mainboard/google/zork/... PS11, Line 118: /* There's no bluetooth device on XHCI1 on Dalboz */ : if (CONFIG(BOARD_GOOGLE_BASEBOARD_DALBOZ)) : return;
nit: Is this check required now? This function should not get called for dalboz at all based on the […]
It's just defensive. It's not clear from the function name that it does not apply to dalboz.