Attention is currently required from: Vinod Polimera, Ravi kumar, Shelley Chen, Mars Chen, mturney mturney. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 22:
(4 comments)
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/f71ba23b_744a9265 PS13, Line 81: lanes
some mipi panels can have 1,2 or 4 lanes. so i have added conditional check.
Ack
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/7be42c9c_0d818c5c PS22, Line 79: (pinfo->lanes > 0) ? pinfo->lanes : 4; `pinfo` is a NULL pointer in the eDP case, so this needs to be
uint32_t lanes = pinfo ? pinfo->lanes : 4;
(assuming that the MIPI panels all define a valid lane count).
Please make sure you test these patches with both MIPI and eDP boards so we don't add regressions to the latter.
https://review.coreboot.org/c/coreboot/+/52662/comment/8d5ff23a_900abc33 PS22, Line 102: const struct panel_data *pinfo; Actually, in order to make sure pinfo is definitely a NULL pointer (and not just undefined stack garbage) in the eDP case, you need to explicitly initialize it here:
const struct panel_data *pinfo = NULL;
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/592fab58_1082e1d2 PS13, Line 163: DSI_PCLK_ON
yes, this should be PCLK only by default.
Ack