Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34710 )
Change subject: soc/intel/{cnl,icl}: Add provision to use PIRX PCI IRQ acpi package ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/34710/2/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/34710/2/src/soc/intel/cannonlake/ac... PS2, Line 149: Return nit: space after Return
https://review.coreboot.org/c/coreboot/+/34710/2/src/soc/intel/icelake/acpi/... File src/soc/intel/icelake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/34710/2/src/soc/intel/icelake/acpi/... PS2, Line 142: ( nit: space after if
https://review.coreboot.org/c/coreboot/+/34710/2/src/soc/intel/icelake/acpi/... PS2, Line 143: Return nit: space after return