Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44158 )
Change subject: mb/google/zork: Use dev_nested_path for dmic gpio update ......................................................................
Patch Set 3:
(14 comments)
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: rewrote
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: gpio machine
DMIC GPIO for ACP machine device
Done
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: Created
Please use present tense.
Done
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@10 PS1, Line 10: new find_dev_nested_path function
“new” to me implies, it’s added in this commit. But it’s already there.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 16: acp_machine_path
This can live within update_dmic_gpio().
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 55: struct : drivers_i2c_generic_config * cfg; struct acpi_gpio *gpio;
Unrelated change.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 65:
Unrelated change. Not required.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 80: void
static void
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 82: struct
Move to next line.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 83: struct acpi_gpio *gpio;
Move to next line.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 83:
No space after *
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 92: __func__);
This should fit in 96 characters.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 101: gpio = &cfg->dmic_select_gpio;
Move to next line.
Done
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 110: update_hp_int_odl
This function name should remain as variant_audio_update().
Done