11 Feb
2019
11 Feb
'19
10:23 p.m.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31318 )
Change subject: soc/amd/common: Move PI refcode loader ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
I only gave a cursory glance at the new file. Those functions were copied verbatim, correct?
https://review.coreboot.org/#/c/31318/3/src/soc/amd/common/block/pi/refcode_... File src/soc/amd/common/block/pi/refcode_loader.c:
https://review.coreboot.org/#/c/31318/3/src/soc/amd/common/block/pi/refcode_... PS3, Line 4: 2017
As this is a new file (though old code), maybe 2019?
It's only moving source that was already copyrighted in 2017, not new source developed in 2019.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68885e7f855b195c178e746c8f3f0f49166d0def
Gerrit-Change-Number: 31318
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Feb 2019 22:23:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment