Attention is currently required from: Furquan Shaikh, Paul Menzel, Sridhar Siricilla, Deepti Deshatty, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54733 )
Change subject: mb/google/volteer:intel/common/block: Move mainboard api to tcss common block
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120535):
https://review.coreboot.org/c/coreboot/+/54733/comment/8cc0dbab_e31a753d
PS6, Line 352: {.type = DEVICE_PATH_GENERIC, .generic.id=0, .generic.subid=0},
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120535):
https://review.coreboot.org/c/coreboot/+/54733/comment/599fdb4d_f1c2380c
PS6, Line 352: {.type = DEVICE_PATH_GENERIC, .generic.id=0, .generic.subid=0},
spaces required around that '=' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7894363df4862f7cfe733d93e6160677fb8a9e31
Gerrit-Change-Number: 54733
Gerrit-PatchSet: 6
Gerrit-Owner: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 13:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment