Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )
Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG@12 PS1, Line 12: TODO: Find out if this is intentional or a bug. I think this was either an oversight or these bits didn't exist in stoney where this code originated.
If you wanted, you could go back and check stoney, and if they weren't there you could surround them with a #ifndef config_soc_amd_stoney.