Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38664 )
Change subject: mb/intel/glkrvp: Simplify FMAP file ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38664/1/src/mainboard/intel/glkrvp/... File src/mainboard/intel/glkrvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38664/1/src/mainboard/intel/glkrvp/... PS1, Line 26: RW_VPD(PRESERVE) 0x2000 Let's calculate the absolute position of this. Before, it was like this:
[RW_VPD pos in FLASH] = [MISC_RW pos in FLASH] + [RW_VPD pos in MISC_RW]
pos = 0x400000 + 0x39000 = 0x439000
Now, we do a similar thing:
[RW_VPD pos in FLASH] = [WP_RO size] + [UNIFIED_MRC_CACHE size] + [RW_ELOG size] + [RW_SHARED size]
pos = 0x400000 + 0x31000 + 0x4000 + 0x4000 = 0x439000
I mean, it's not much more complicated. If you have an hex calculator (or Google), it's a piece of cake.