build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28344 )
Change subject: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28344/2/src/soc/amd/stoneyridge/include/soc/...
File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/28344/2/src/soc/amd/stoneyridge/include/soc/...
PS2, Line 311: #define DEBUG_PORT_MASK (BIT(16) | BIT(17) | (BIT(18))
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/28344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb25992729d984b8570712f91a03a7cd1e9b8643
Gerrit-Change-Number: 28344
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Aug 2018 15:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No