build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Support to initialize Memory ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... PS14, Line 356: if (( info->topology == MEMORY_DOWN ) || ( info->topology == MIXED )) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... PS14, Line 356: if (( info->topology == MEMORY_DOWN ) || ( info->topology == MIXED )) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... PS14, Line 361: if ( info->topology == SODIMM ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... PS14, Line 361: if ( info->topology == SODIMM ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/39847/14/src/soc/intel/tigerlake/me... PS14, Line 366: for (unsigned int i = 0; i< DDR4_CHANNELS; i++) { spaces required around that '<' (ctx:VxW)