Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45447 )
Change subject: util/rockchip: Port make_idb.py to python3
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45447/7/util/rockchip/make_idb.py
File util/rockchip/make_idb.py:
https://review.coreboot.org/c/coreboot/+/45447/7/util/rockchip/make_idb.py@5...
PS7, Line 53: assert len(chip.encode('ascii')) == 4
Either
assert len(chip) == 4
since encoding in ascii should preserve length, or,
chip_bytes = chip.encode('ascii')
assert len(chip_bytes) == 4
buf[:4] = chip_bytes
to avoid encoding twice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04253084ec9b65310c52598b629390051cd2172b
Gerrit-Change-Number: 45447
Gerrit-PatchSet: 7
Gerrit-Owner: Yilin Yang
kerker@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 07:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment