build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26942 )
Change subject: src: Use "foo *bar" instead of "foo* bar" ......................................................................
Patch Set 9:
(37 comments)
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h File src/device/oprom/yabel/compat/of.h:
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@3... PS9, Line 38: #define p32cast (int) (unsigned long) (void *) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 53: phandle_t of_peer(phandle_t); function definition argument 'phandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 54: phandle_t of_child(phandle_t); function definition argument 'phandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 55: phandle_t of_parent(phandle_t); function definition argument 'phandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 56: int of_getprop(phandle_t, const char *, void *, int); function definition argument 'phandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 56: int of_getprop(phandle_t, const char *, void *, int); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 56: int of_getprop(phandle_t, const char *, void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 56: int of_getprop(phandle_t, const char *, void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 57: void *of_call_method_3(const char *, ihandle_t, int); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 57: void *of_call_method_3(const char *, ihandle_t, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@5... PS9, Line 57: void *of_call_method_3(const char *, ihandle_t, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 60: ihandle_t of_open(const char *); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 62: int of_read(ihandle_t, void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 62: int of_read(ihandle_t, void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 62: int of_read(ihandle_t, void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 66: void *of_claim(void *, unsigned int, unsigned int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 66: void *of_claim(void *, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 66: void *of_claim(void *, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 67: void of_release(void *, unsigned int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@6... PS9, Line 67: void of_release(void *, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 70: void *of_set_callback(void *); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 74: int write_mm_log(char *, unsigned int, unsigned short); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 74: int write_mm_log(char *, unsigned int, unsigned short); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/device/oprom/yabel/compat/of.h@7... PS9, Line 74: int write_mm_log(char *, unsigned int, unsigned short); function definition argument 'unsigned short' should also have an identifier name
https://review.coreboot.org/#/c/26942/9/src/northbridge/amd/amdht/ht_wrapper... File src/northbridge/amd/amdht/ht_wrapper.c:
https://review.coreboot.org/#/c/26942/9/src/northbridge/amd/amdht/ht_wrapper... PS9, Line 58: static const char *event_class_string_decodes[] = { static const char * array should probably be static const char * const