Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42144 )
Change subject: mb/google/poppy: Drop VARIANT_SPECIFIC_OPTIONS_* ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42144/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42144/1//COMMIT_MSG@9 PS1, Line 9: Putting variant-specific options in Kconfig.name seems to be what is : popular now
More recent google boards do it, for example Hatch. […]
wasn't suggesting we get rid of it, just noting that it makes it much harder to figure out which board-level symbols are being selected when you have to jump back and forth between two files.
and I guess I kinda started this when I migrated all the Glados boards to a variant setup