View Change
1 comment:
Commit Message:
Patch Set #1, Line 9:
Putting variant-specific options in Kconfig.name seems to be what is
popular now
More recent google boards do it, for example Hatch. […]
wasn't suggesting we get rid of it, just noting that it makes it much harder to figure out which board-level symbols are being selected when you have to jump back and forth between two files.
and I guess I kinda started this when I migrated all the Glados boards to a variant setup
To view, visit change 42144. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ce3237ac620c26856b6cf3d08293729641dd0b0
Gerrit-Change-Number: 42144
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 07 Jun 2020 18:30:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment