Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44790 )
Change subject: gma: Add Bay Trail options ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/libgfxinit/+/44790/3/common/hw-gfx-gma-config.... File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/44790/3/common/hw-gfx-gma-config.... PS3, Line 322: looked
looked *up*?
Done
https://review.coreboot.org/c/libgfxinit/+/44790/5/common/hw-gfx-gma-panel.a... File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/44790/5/common/hw-gfx-gma-panel.a... PS5, Line 275: if Config.Gen_Valleyview then Should have its own flag, e.g. `Has_VLV_PP_Port_Select` and the other could be renamed to `Has_PCH_PP_Port_Select`.