Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 39: ///< Offset 0 Index of Component Name
There are some lines that are (unnecessary) too long. […]
Yes Werner, this is the standard version across all platforms. WOuld you mind to provide +2 if you are alright with this? :)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 3027:
This is a looong list of parameters...just for Fspm.
Yes you are right haha.. but i don't have control over this :P