Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48597 )
Change subject: trace: Use dynamic address bytes everywhere we should.
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/em100/+/48597/1/trace.c
File trace.c:
https://review.coreboot.org/c/em100/+/48597/1/trace.c@292
PS1, Line 292: printf("%02x ", data[i * 8 + address_bytes + 1 + j]);
I think this one can be removed here as it has been added here: j = 1 + address_bytes + spi_cmd_vals->pad_bytes;
--
To view, visit
https://review.coreboot.org/c/em100/+/48597
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I0614bd39d0b47331ffb96195da3624240ef29ffa
Gerrit-Change-Number: 48597
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Dec 2020 10:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment