24 Feb
2020
24 Feb
'20
8:10 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39090 )
Change subject: mb/supermicro/x11-lga1151-series: fix GPIO reset mapping ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Doesn't make it easier to read, though, looks like hardware values but isn't. Better to get rid of _PAD_CFG_STRUCT(), it's not intended for the mainboard level.
Agreed. As soon as I have a little time I could try to complete Maxims work on that go converter (there were some bits missing).
--
To view, visit https://review.coreboot.org/c/coreboot/+/39090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ae17dfc4d90f88f5b8bc5bee49740745778a91a
Gerrit-Change-Number: 39090
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 16:10:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment