Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: soc/intel: Add mem_rank info in SMBIOS ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/31235/11/src/soc/intel/apollolake/meminit_ut... File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/31235/11/src/soc/intel/apollolake/meminit_ut... PS11, Line 88: src_dimm->RankInDimm Build bot seems to be failing because this field is not present in DIMM_INFO. Is it updated as part of FSP headers already?