Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48068 )
Change subject: soc/intel/common/fast_spi: Add Lockdown of extended BIOS region ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48068/2/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/48068/2/src/soc/intel/common/block/... PS2, Line 74: uint8_t uint32_t
https://review.coreboot.org/c/coreboot/+/48068/2/src/soc/intel/common/block/... PS2, Line 77: bc_cntl = pci_read_config32(dev, SPIBAR_BIOS_CONTROL); : bc_cntl |= bios_cntl_bit; : pci_write_config32(dev, SPIBAR_BIOS_CONTROL, bc_cntl); This can be changed to pci_or_config32, right?
https://review.coreboot.org/c/coreboot/+/48068/2/src/soc/intel/common/block/... PS2, Line 97: fast_spi_read_post_write(SPIBAR_BIOS_CONTROL); Not for this change, but I think we should move the call to fast_spi_read_post_write() inside fast_spi_set_bios_control_reg().