chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee...
PS1, Line 147: ACPI_GPIO_IRQ_LEVEL_LOW(
Could you help check the spec for which mode this irq triggered? edge or level?
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee...
PS1, Line 158: ACPI_GPIO_IRQ_LEVEL_LOW
the same as above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I002badd49e678e1c32c802352923ca51efb45cef
Gerrit-Change-Number: 35000
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 06:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment