Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee/var/baseboard: Enable mode change wake source for S3/S0ix
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7
PS1, Line 7: /S0ix
The grunt boards don't support S0ix
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@10
PS1, Line 10:
Is there a bug for this? Why is this needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95b1eac800858ab17cdf69bdd3f2c5828516c184
Gerrit-Change-Number: 31429
Gerrit-PatchSet: 1
Gerrit-Owner: Mengqi Guo
mqg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mengqi Guo
mqg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Feb 2019 15:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment