Change in ...coreboot[master]: mb/google/kahlee/var/baseboard: Enable mode change wake source for S3...
Mengqi Guo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31429
Change subject: mb/google/kahlee/var/baseboard: Enable mode change wake source for S3/S0ix ......................................................................
mb/google/kahlee/var/baseboard: Enable mode change wake source for S3/S0ix
This change enables mode change as a wake source for S3 and S0ix.
Change-Id: I95b1eac800858ab17cdf69bdd3f2c5828516c184 Signed-off-by: Mengqi Guo mqg@chromium.org --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h 1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31429/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h index 976b621..ae648b5 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h @@ -44,10 +44,14 @@ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))
-/* EC can wake from S3 with lid or power button or key press */ +/* + * EC can wake from S3 with lid or power button or key press or + * mode change event + */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
/* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee/var/baseboard: Enable mode change wake source for S3/S0ix ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: mb/google/kahlee/var/baseboard mb/google/kahlee should be sufficient.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee/var/baseboard: Enable mode change wake source for S3/S0ix ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: /S0ix The grunt boards don't support S0ix
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@10 PS1, Line 10: Is there a bug for this? Why is this needed?
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31429
to look at the new patch set (#2).
Change subject: mb/google/kahlee: Enable mode change as wake source for S3 ......................................................................
mb/google/kahlee: Enable mode change as wake source for S3
This change enables mode change as a wake source for S3.
BUG=b:124132058
Change-Id: I95b1eac800858ab17cdf69bdd3f2c5828516c184 Signed-off-by: Mengqi Guo mqg@chromium.org --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h 1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31429/2
Mengqi Guo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee: Enable mode change as wake source for S3 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: /S0ix
The grunt boards don't support S0ix
Thanks for pointing it out!
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@7 PS1, Line 7: mb/google/kahlee/var/baseboard
mb/google/kahlee should be sufficient.
Done
https://review.coreboot.org/#/c/31429/1//COMMIT_MSG@10 PS1, Line 10:
Is there a bug for this? Why is this needed?
Attached bug number. This is for managing waking from touchpad.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31429 )
Change subject: mb/google/kahlee: Enable mode change as wake source for S3 ......................................................................
mb/google/kahlee: Enable mode change as wake source for S3
This change enables mode change as a wake source for S3.
BUG=b:124132058
Change-Id: I95b1eac800858ab17cdf69bdd3f2c5828516c184 Signed-off-by: Mengqi Guo mqg@chromium.org Reviewed-on: https://review.coreboot.org/c/31429 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h 1 file changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h index 976b621..ae648b5 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h @@ -44,10 +44,14 @@ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))
-/* EC can wake from S3 with lid or power button or key press */ +/* + * EC can wake from S3 with lid or power button or key press or + * mode change event + */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
/* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \
-
Furquan Shaikh (Code Review) -
Martin Roth (Code Review)
-
Mengqi Guo (Code Review)
-
Patrick Georgi (Code Review)