Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46587 )
Change subject: lenovo/g505s: properly program the IRQ table ......................................................................
Patch Set 4:
(2 comments)
After getting just 1 IRQ working at first attempt (copy-pasted the values of the old picr_data/intr_data), now I blindly copied the mainboard_picr_data/mainboard_intr_data structures to G505S from asus/am1i-a - and got 12 IRQs working! coreboot log: https://pastebin.com/pXYK2agv , KolibriOS screenshot: https://i.ibb.co/3vPVGHr/g505s-kolibrios-2nd-rev.png . However, at the IRQ table there are still 00 for some important devices!
Could someone explain to me, how to properly compose all these tables? I'm also unsure if did the irq_tables.c correct. Please help, and this successful experience could be spread to other AMD fam15h boards: all of them have a bad IRQ routing that somehow works with a complex Linux, but fails in a simple OS like Kolibri.
https://review.coreboot.org/c/coreboot/+/46587/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46587/2//COMMIT_MSG@7 PS2, Line 7: lenovo/g505s: proper way of IRQ table programming
Please make it a statement by adding a verb in imperative mood: […]
Done.
https://review.coreboot.org/c/coreboot/+/46587/2/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46587/2/src/mainboard/lenovo/g505s/... PS2, Line 95: **********************************************/
I’d remove the comment, as it does not add more information than deduced from the function name, and […]
Done.