Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45879 )
Change subject: soc: move mainboard_get_dram_part_num prototype to memory_info.h
......................................................................
Patch Set 1:
BTW you need another change to move the weak definition out of the SoC files and into common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b228475621ca1035fe13f8311355fc3b926e897
Gerrit-Change-Number: 45879
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Sep 2020 23:28:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment