build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47788 )
Change subject: soc/intel/jasperlake: [TEST-ONLY] SPI read CAR test ......................................................................
Patch Set 1:
(27 comments)
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... File src/soc/intel/jasperlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 30: struct cpuid_result res; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 31: uintptr_t addr = 0xFF000000; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 32: char buf[1024]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 33: uint32_t kbcount=0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 33: uint32_t kbcount=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 34: res = cpuid_ext(0x04, 0x03); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 35: const size_t assoc = CPUID_CACHE_WAYS_OF_ASSOC(res) + 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 36: const size_t partitions = CPUID_CACHE_PHYS_LINE(res) + 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 37: const size_t cache_line_size = CPUID_CACHE_COHER_LINE(res) + 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 38: const size_t number_of_sets = CPUID_CACHE_NO_OF_SETS(res) + 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 39: const size_t cache_size = assoc * partitions * cache_line_size * number_of_sets; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 40: printk(BIOS_INFO, "assoc=%zd par=%zd line_size=%zd sets=%zd\n", please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 41: assoc, partitions, cache_line_size, number_of_sets); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 41: assoc, partitions, cache_line_size, number_of_sets); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 42: printk(BIOS_INFO, "@@ dedede cache_size 0x%lx bytes\n", cache_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 44: while (addr < 0xFFFF0000) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 44: while (addr < 0xFFFF0000) { suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 45: memcpy(buf, (void *)addr, 1024); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 45: memcpy(buf, (void *)addr, 1024); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 46: printk(BIOS_ERR, "TEST : %lx %x KBcount : %d \n", addr, buf[0], kbcount); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 46: printk(BIOS_ERR, "TEST : %lx %x KBcount : %d \n", addr, buf[0], kbcount); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 46: printk(BIOS_ERR, "TEST : %lx %x KBcount : %d \n", addr, buf[0], kbcount); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 47: addr += 1024; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 47: addr += 1024; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 48: ++kbcount; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 48: ++kbcount; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47788/1/src/soc/intel/jasperlake/bo... PS1, Line 49: } please, no spaces at the start of a line