build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45410 )
Change subject: mb/ocp/deltalake: Insert IO port in linux command line ......................................................................
Patch Set 1:
(23 comments)
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 297: char *dupstr = strdup((char*)start); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 327: len = strlen(slice[i]); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 327: len = strlen(slice[i]); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 327: len = strlen(slice[i]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 328: found = strstr(slice[i], s); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 328: found = strstr(slice[i], s); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 328: found = strstr(slice[i], s); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 332: for (c = 0; c < pos; c++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 339: for (c = 0; c < (len - pos + 1); c++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 340: *(t2 + c) = *((slice[i] + pos) + c); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 340: *(t2 + c) = *((slice[i] + pos) + c); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 340: *(t2 + c) = *((slice[i] + pos) + c); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 341: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 341: } please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 341: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 342: *(t2 + c) = '\0'; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 342: *(t2 + c) = '\0'; please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 342: *(t2 + c) = '\0'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 350: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 350: } please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 350: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 352: memset((uint8_t*)start, 0, size); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/45410/1/src/mainboard/ocp/deltalake... PS1, Line 353: memcpy((uint8_t*)start, new, strlen(new)); "(foo*)" should be "(foo *)"