5 Nov
2020
5 Nov
'20
5:06 a.m.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47153 )
Change subject: libpayload: Add compiler.h to compiler parameters ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47153/2/payloads/libpayload/include... File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/c/coreboot/+/47153/2/payloads/libpayload/include... PS2, Line 47: #include <compiler.h>
This header file can technically be removed now, but doing so may break other projects that implicit […]
After talking to Jenkins, I have determined it should stay. Reverted.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia67182520dc94149e06fe9e03a14b3fc2ee29973
Gerrit-Change-Number: 47153
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 05:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca
Gerrit-MessageType: comment