Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D
......................................................................
Patch Set 9:
(1 comment)
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/591b74e7_2132d6d1
PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
I modeled NCT6797D on the NTC6791D directly above, and there are no NANA entries. […]
Hi, do you have the datasheet, though? If so, it would be nice to figure out
for which registers a default makes sense, and which should have a NANA. We
can guide you through that if you have the datasheet.
I happen to have the NCT6791D datasheet, so I'm going to write a patch for
that right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Gerrit-Change-Number: 49112
Gerrit-PatchSet: 9
Gerrit-Owner: Clay Daniels
clay.daniels.jr@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Clay Daniels
clay.daniels.jr@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Clay Daniels
clay.daniels.jr@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment