Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38541 )
Change subject: ec/google/chromeec: Add SSDT generator for ChromeOS EC ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38541/11/src/ec/google/chromeec/ec.... File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/38541/11/src/ec/google/chromeec/ec.... PS11, Line 342: board_get_usb_typec_port_paths Do we really need this? Just another thing that the mainboard needs to provide. We already have this information captured in the device tree. Is there a way we could use that instead of having to provide this callback in mainboard?
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
type ==> UPC_TYPE_C_USB2_SS_SWITCH group ==> ACPI_PLD_GROUP(1, 1)
https://review.coreboot.org/c/coreboot/+/38541/11/src/ec/google/chromeec/ec_... File src/ec/google/chromeec/ec_chip.c:
https://review.coreboot.org/c/coreboot/+/38541/11/src/ec/google/chromeec/ec_... PS11, Line 15: SOC_INTEL_COMMON_BLOCK_XHCI We should avoid intel specific references in common ec code. It would be better to have a proper API that can be implemented by any SoC.
https://review.coreboot.org/c/coreboot/+/38541/11/src/ec/google/chromeec/ec_... PS11, Line 125: #if CONFIG(SOC_INTEL_COMMON_BLOCK_XHCI) Instead of having this block here, what do you think about having a callback into the SoC to simply get the acpi path for a USB-C device? You can leave it upto the SoC to determine how to do it.